Forgive me if I am wrong but you seem rather new to painting environments if that´s the case you should avoid using colors in the beginning and focus on greyscale values.
Using color without proper values as a base will give very poor results
here is a method you can try
Start out using values (greyscale) instead of colors, divide you composition into the groups foreground, middleground and background, with foreground being the darkest and background being the brightest this can change depending on the light setting, it is the most commonly used method.
Then you can make a new layer and set it to overlay,color or multiply depending on what you like.
and do studies from photos or real life, alot of studies
try looking at this it might be of some help aswell
Thanks a lot man.. i've been practicing environments for a month or two.. and i have seen all the Feng Zhu videos and tried the value studied.. i do that for every one of my paintings with the black layer on saturation.. but somehow i still get shitty colors. I will do the real life studied that seems like a good idea. Thank you for taking the time to reply i appreciate it
Hi there, these are looking good! Just to throw my two-cents in, I'm not sure you actually have that much of a problem with values. I think your bigger issue is saturation. You could push your values further and use a bigger range, sure, but it looks to me like you don't have all too much difficulty knowing where to put your darks and lights. You seem to have a big problem with color choice though, which comes down to where things are saturated and where they are not. There are a couple of basic rules of thumb about saturation that may help you immensely. In general, colors in life tend to be less saturated the lighter they are, and more saturated the darker they are. This rule can be bent for effect and isn't always a perfect representation of nature, but in general it holds true. Try this in your paintings and you will see the results immediately. I am pretty sure that this is the one and only reason why your colors are not working because I have had the same problem! If you look at my sketchbook, you will immediately see the point where I figured it out haha! The second rule of thumb to think about is not to mix your warm colors with your cool colors. You will get a muddy painting that is not very pleasing to the eye, and it will happen every time. Instead of mixing them, use warm and cool colors in comparison with each other. This will give you a brilliant, popping clarity in your work. Good luck man, you are on the brink of making some wonderful paintings!
"One can easily get lost in a lot of little truths without seeing the big ones" - Andrew Loomis SketchBook